Make the switch to implementing own stubs easier #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Figured out the Would like feedback on the |
|
I made a quick commit that addresses a few typos and fixes up a bit of formatting. Please have a look and make sure I didn't screw anything up. Otherwise this looks good to me. |
ryanplusplus
reviewed
Jan 6, 2018
|
|
||
| Before you are finished with the header file, you should add include guards. | ||
| Include guards are used to help prevent the file from being included multiple times by accident. | ||
| If the file _was_ included multiple times then the functions and other items would be declared twice; In C this is an error because the compiler thinks you are trying to declare another _different_ function that has the same name. |
There was a problem hiding this comment.
The ; could probably just be a ., but I tried to take only a half step away from the em dash.
|
Thanks @ryanplusplus I've now added hints to the other two relevant exercises and regenerated the README.md files. So this PR should be good to go. |
For gigasecond, meetup and space-age
wolf99
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is opened with regard to #252 where it was decided to add headers for the core exercise
isogramand the non-core exercises that it unlocks, and also to addhints.mdfiles for the following core exercisegigasecondand the non-core exercises that it unlocks to explain how a student should add their own headers.I have so far added the stub headers to
isogram,acronymandpangram.I have also added a first draft of a
hints.mdfile togigasecondThe
hints.mdfile also needs to be added tospace-ageandmeetup. I delay in adding them to make any edits that anyone suggests to thegigasecondone before copying it over.Also, I am not sure how to correctly regenerate the README.md. I have downloaded the
configletand unzipped it, then cloned theproblem-specificationsrepository to the same directory (which also holds thecrepository). Then in the root of thecrepository I run../configlet generate . --only gigasecond --spec-path ../problem-specifications(all as outlined here: exercism/java#1085)
But nothing seems to happen and the
README.mdremains unchanged... What have I done wrong?